Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document streaming #49

Merged
merged 19 commits into from
Apr 27, 2024
Merged

document streaming #49

merged 19 commits into from
Apr 27, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

README.md Show resolved Hide resolved
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (9f8f4e5) to head (3d2fac5).

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #49   +/-   ##
==================================
  Coverage    82%   82%           
==================================
  Files         6     6           
  Lines       439   439           
==================================
  Hits        361   361           
  Misses       78    78           

@aniketmaurya aniketmaurya marked this pull request as ready for review April 17, 2024 14:48
@aniketmaurya aniketmaurya changed the title document streaming [WIP] document streaming Apr 17, 2024
README.md Show resolved Hide resolved
@aniketmaurya aniketmaurya changed the title [WIP] document streaming document streaming Apr 19, 2024
@aniketmaurya aniketmaurya added the documentation Improvements or additions to documentation label Apr 23, 2024
@aniketmaurya aniketmaurya self-assigned this Apr 23, 2024
@aniketmaurya aniketmaurya enabled auto-merge (squash) April 23, 2024 21:07
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled April 24, 2024 15:23

Pull Request is not mergeable

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment. We also need to mention (in an advanced section) that batching supports streaming, and if you need a custom batch/unbatch implementation, that should also yield.

README.md Outdated Show resolved Hide resolved
aniketmaurya and others added 2 commits April 25, 2024 12:00
Co-authored-by: Luca Antiga <[email protected]>
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@williamFalcon williamFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce the imports by following my guide

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamFalcon williamFalcon merged commit ff7f0c8 into main Apr 27, 2024
19 checks passed
@williamFalcon williamFalcon deleted the aniket/document-stream branch April 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants