-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batched streaming #55
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==================================
- Coverage 83% 82% -1%
==================================
Files 6 6
Lines 381 426 +45
==================================
+ Hits 318 351 +33
- Misses 63 75 +12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far
@lantiga we would also need to document on how are we going to batch requests with different argument like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aniketmaurya this is looking good! Let's remove the [wip] and get it merged
@lantiga please feel free to approve and merge. |
Before submitting
What does this PR do?
Enables batched streaming #45
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃