Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batched streaming #55

Merged
merged 21 commits into from
Apr 24, 2024
Merged

batched streaming #55

merged 21 commits into from
Apr 24, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Apr 22, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Enables batched streaming #45

  • Update tests

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya self-assigned this Apr 22, 2024
@aniketmaurya aniketmaurya added the enhancement New feature or request label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Merging #55 (fc4927f) into main (38b5b09) will decrease coverage by 1%.
The diff coverage is 69%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #55   +/-   ##
==================================
- Coverage    83%   82%   -1%     
==================================
  Files         6     6           
  Lines       381   426   +45     
==================================
+ Hits        318   351   +33     
- Misses       63    75   +12     

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far

src/litserve/server.py Outdated Show resolved Hide resolved
src/litserve/server.py Show resolved Hide resolved
@aniketmaurya
Copy link
Collaborator Author

@lantiga we would also need to document on how are we going to batch requests with different argument like temperature etc.

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aniketmaurya this is looking good! Let's remove the [wip] and get it merged

@aniketmaurya aniketmaurya changed the title [wip] batched streaming batched streaming Apr 23, 2024
@aniketmaurya aniketmaurya enabled auto-merge (squash) April 23, 2024 19:03
@aniketmaurya
Copy link
Collaborator Author

@lantiga please feel free to approve and merge.

@aniketmaurya aniketmaurya merged commit b0ed683 into main Apr 24, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/batched-stream branch April 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants