Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos CI #62

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Fix macos CI #62

merged 6 commits into from
Apr 24, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Apr 24, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

GitHub has updated macos-latest from macos-12 to macos-14-arm64 and it broke CI. Fixes #60

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Merging #62 (7d8f111) into main (ed31d63) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #62   +/-   ##
==================================
  Coverage    83%   83%           
==================================
  Files         6     6           
  Lines       376   381    +5     
==================================
+ Hits        312   318    +6     
+ Misses       64    63    -1     

@lantiga lantiga merged commit 38b5b09 into main Apr 24, 2024
19 checks passed
@lantiga lantiga deleted the aniket/fix-macos-ci branch April 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants