Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document batching #65

Merged
merged 17 commits into from
Apr 29, 2024
Merged

document batching #65

merged 17 commits into from
Apr 29, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya added the documentation Improvements or additions to documentation label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (6906a5d) to head (4f368fa).

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #65   +/-   ##
==================================
  Coverage    82%   82%           
==================================
  Files         6     6           
  Lines       439   439           
==================================
  Hits        361   361           
  Misses       78    78           

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, added comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think the examples would benefit a lot from an example request and response, so you have a better understanding of what to expect

README.md Outdated Show resolved Hide resolved
Co-authored-by: Luca Antiga <[email protected]>
@aniketmaurya
Copy link
Collaborator Author

Looks good, but I think the examples would benefit a lot from an example request and response, so you have a better understanding of what to expect

@lantiga did you mean to have a full example instead of the ... as follows?

class SimpleStreamAPI(ls.LitAPI):
    # add encode_response and decode_response here as well
    ...

    def batch(self, inputs):
        return np.stack(inputs)

    def unbatch(self, output):
        return list(output)

    ...

@lantiga
Copy link
Collaborator

lantiga commented Apr 29, 2024

No I mean what the input and output data payloads look like for each case (especially for batching).

Let's keep it for a separate enhancement, just resolve the conflict for now and we merge.

@aniketmaurya aniketmaurya merged commit 47bcbc9 into main Apr 29, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/document-batching branch April 29, 2024 12:18
@aniketmaurya aniketmaurya mentioned this pull request Apr 30, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants