-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document batching #65
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==================================
Coverage 82% 82%
==================================
Files 6 6
Lines 439 439
==================================
Hits 361 361
Misses 78 78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think the examples would benefit a lot from an example request and response, so you have a better understanding of what to expect
Co-authored-by: Luca Antiga <[email protected]>
@lantiga did you mean to have a full example instead of the class SimpleStreamAPI(ls.LitAPI):
# add encode_response and decode_response here as well
...
def batch(self, inputs):
return np.stack(inputs)
def unbatch(self, output):
return list(output)
... |
No I mean what the input and output data payloads look like for each case (especially for batching). Let's keep it for a separate enhancement, just resolve the conflict for now and we merge. |
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃