Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading function for merge_datasets #413

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

yhl48
Copy link
Contributor

@yhl48 yhl48 commented Nov 8, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds multithreading to merge_datasets

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@yhl48 yhl48 requested a review from tchaton as a code owner November 8, 2024 18:18
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (ac0c89b) to head (7555aaf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #413   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5052   5056    +4     
===================================
+ Hits       3960   3964    +4     
  Misses     1092   1092           

Copy link
Collaborator

@bhimrazy bhimrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😊, thanks @yhl48! 🎉

@bhimrazy bhimrazy merged commit cedc6a6 into Lightning-AI:main Nov 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants