Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump macos to m1 #1725

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

bump macos to m1 #1725

wants to merge 20 commits into from

Conversation

t-vi
Copy link
Contributor

@t-vi t-vi commented Sep 13, 2024

some discussion on #1724

seems to run into segfaults. obviously, if anyone with a macbook or so could take over sorting things out, it would be supergood.

@Andrei-Aksionov
Copy link
Collaborator

Tried to run API tests locally on M3 chip and had no issues.
Unfortunately, I have no time to debug it.
@rasbt all hope is on you.

P.S. Here is an interesting project: https://github.com/mxschmitt/action-tmate
Haven't tried it, but in theory it should allow you to connect to a runner and check what's what.

@t-vi t-vi marked this pull request as draft September 13, 2024 09:30
@t-vi
Copy link
Contributor Author

t-vi commented Sep 13, 2024

So by commenting out the LLM imports, it makes the segfaults go away, but isn't a realistic option.
Also, tons of failing tests.

@rasbt rasbt mentioned this pull request Sep 13, 2024
@rasbt
Copy link
Collaborator

rasbt commented Sep 16, 2024

It's a bit of a weird machine. The memory issues aside, I am also seeing

FAILED tests/test_convert_lit_checkpoint.py::test_against_original_gemma_2[device0-dtype0-gemma-2-27b] - AssertionError: Tensor-likes are not close!
Mismatched elements: 305 / 5120000 (0.0%)
Greatest absolute difference: 1.7881393432617188e-05 at index (0, 13, 73469) (up to 1e-05 allowed)

It works perfectly fine locally on both my Macs on M1 and M3. I am also using macOS 14.

@t-vi
Copy link
Contributor Author

t-vi commented Sep 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants