-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump macos to m1 #1725
base: main
Are you sure you want to change the base?
bump macos to m1 #1725
Conversation
Tried to run API tests locally on M3 chip and had no issues. P.S. Here is an interesting project: https://github.com/mxschmitt/action-tmate |
So by commenting out the LLM imports, it makes the segfaults go away, but isn't a realistic option. |
It's a bit of a weird machine. The memory issues aside, I am also seeing
It works perfectly fine locally on both my Macs on M1 and M3. I am also using macOS 14. |
Thank you for looking into this. I'd not worry much about that. This can happen from different rng seeds, test order etc. Probably OK to just increase the tolerance to 3e-5 or so.
Am 16. September 2024 19:42:14 MESZ schrieb Sebastian Raschka ***@***.***>:
…It's a bit of a weird machine. The memory issues aside, I am also seeing
> FAILED tests/test_convert_lit_checkpoint.py::test_against_original_gemma_2[device0-dtype0-gemma-2-27b] - AssertionError: Tensor-likes are not close!
Mismatched elements: 305 / 5120000 (0.0%)
Greatest absolute difference: 1.7881393432617188e-05 at index (0, 13, 73469) (up to 1e-05 allowed)
It works perfectly fine locally on both my Macs on M1 and M3. I am also using macOS 14.
--
Reply to this email directly or view it on GitHub:
#1725 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
some discussion on #1724
seems to run into segfaults. obviously, if anyone with a macbook or so could take over sorting things out, it would be supergood.