Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated APIs that should've been removed in the past releases #15618

Closed
akihironitta opened this issue Nov 10, 2022 · 1 comment · Fixed by #15637
Closed

Remove deprecated APIs that should've been removed in the past releases #15618

akihironitta opened this issue Nov 10, 2022 · 1 comment · Fixed by #15637
Assignees
@akihironitta
Labels
breaking change Includes a breaking change code quality
Milestone
v1.9

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Nov 10, 2022 •
edited by github-actions bot
Loading

Proposed refactor

Here's a quick list of APIs to remove (there can be false negative).

$ git grep -n "deprecated::"|egrep -v "1.7|1.8|1.9"
src/pytorch_lightning/profiler/base.py:28:    .. deprecated:: v1.6
src/pytorch_lightning/profiler/base.py:56:    .. deprecated:: v1.6
src/pytorch_lightning/profiler/profiler.py:20:    .. deprecated:: v1.6
src/pytorch_lightning/trainer/trainer.py:175:                .. deprecated:: v1.5
src/pytorch_lightning/trainer/trainer.py:345:                .. deprecated:: v1.5
src/pytorch_lightning/utilities/memory.py:101:    .. deprecated:: v1.5

cc @Borda @justusschock
@akihironitta akihironitta added breaking change Includes a breaking change code quality labels Nov 10, 2022
@akihironitta akihironitta self-assigned this Nov 10, 2022
@akihironitta akihironitta mentioned this issue Nov 10, 2022
Merged
12 tasks
@carmocca carmocca moved this to In Progress in Frameworks Planning Nov 10, 2022
@carmocca carmocca added this to the v1.9 milestone Nov 10, 2022
This was referenced Nov 11, 2022
Merged
Merged
@akihironitta
Copy link
Contributor Author

I believe I opened PRs for removing all missed deprecated APIs. There are still deprecated APIs that will be removed in v1.9, but it is out of the scope of this issue.

Repository owner moved this from In Progress to Done in Frameworks Planning Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akihironitta akihironitta

Labels
breaking change Includes a breaking change code quality
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.9
2 participants
@carmocca @akihironitta