-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove get_gpu_memory_map
deprecated since v1.5
#15617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
added
breaking change
Includes a breaking change
accelerator: cuda
Compute Unified Device Architecture GPU
labels
Nov 10, 2022
akihironitta
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
November 10, 2022 07:47
Not sure which milestone this change is part of, v1.8.x or v1.9. |
awaelchli
approved these changes
Nov 10, 2022
Removals of deprecated API always goes to milestone 1.X.0 :) |
Borda
approved these changes
Nov 10, 2022
On the other hand this is supposed to be removed already fro 1.7.0 😇 |
carmocca
reviewed
Nov 10, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
akihironitta
force-pushed
the
remove-deprecated-get-gpu-memory-map
branch
from
November 11, 2022 01:36
f75c86e
to
841b354
Compare
for more information, see https://pre-commit.ci
carmocca
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: cuda
Compute Unified Device Architecture GPU
breaking change
Includes a breaking change
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #15618.
The API was deprecated in #9921.
Does your PR introduce any breaking changes? If yes, please list them.
Removes
in favor of
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @akihironitta