Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_gpu_memory_map deprecated since v1.5 #15617

Merged
merged 9 commits into from
Nov 11, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Nov 10, 2022

What does this PR do?

Part of #15618.
The API was deprecated in #9921.

Does your PR introduce any breaking changes? If yes, please list them.

Removes

pytorch_lightning.utilities.memory.get_gpu_memory_map

in favor of

pytorch_lightning.accelerators.cuda.get_nvidia_gpu_stats

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @akihironitta

@akihironitta akihironitta added breaking change Includes a breaking change accelerator: cuda Compute Unified Device Architecture GPU labels Nov 10, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 10, 2022
@akihironitta
Copy link
Contributor Author

Not sure which milestone this change is part of, v1.8.x or v1.9.

@awaelchli
Copy link
Contributor

Not sure which milestone this change is part of, v1.8.x or v1.9.

Removals of deprecated API always goes to milestone 1.X.0 :)

@awaelchli awaelchli added this to the v1.9 milestone Nov 10, 2022
@akihironitta akihironitta self-assigned this Nov 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@Borda
Copy link
Member

Borda commented Nov 10, 2022

Not sure which milestone this change is part of, v1.8.x or v1.9.

Removals of deprecated API always goes to milestone 1.X.0 :)

On the other hand this is supposed to be removed already fro 1.7.0 😇

@akihironitta akihironitta force-pushed the remove-deprecated-get-gpu-memory-map branch from f75c86e to 841b354 Compare November 11, 2022 01:36
src/pytorch_lightning/_graveyard/__init__.py Outdated Show resolved Hide resolved
@akihironitta akihironitta enabled auto-merge (squash) November 11, 2022 02:41
@akihironitta akihironitta merged commit a7befe1 into master Nov 11, 2022
@akihironitta akihironitta deleted the remove-deprecated-get-gpu-memory-map branch November 11, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: cuda Compute Unified Device Architecture GPU breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants