Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightningCLI support for optimizers and schedulers via dependency injection #15869

Merged
merged 6 commits into from
Dec 12, 2022
Merged

LightningCLI support for optimizers and schedulers via dependency injection #15869

merged 6 commits into from
Dec 12, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Nov 30, 2022

What does this PR do?

Current LightningCLI's support for multiple optimizers and schedulers using dict as a type is a non-optimal solution. This pull request adds support for having a proper type hint for these kind of parameters and be in line with how multiple submodules work. The details are explained in the updates to the documentation.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 30, 2022
@mauvilsa mauvilsa marked this pull request as ready for review November 30, 2022 06:15
@mauvilsa mauvilsa changed the title LightningCLI support for optimizer and schedulers via dependency injection LightningCLI support for optimizers and schedulers via dependency injection Nov 30, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels Nov 30, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 30, 2022
@mergify mergify bot added the has conflicts label Dec 6, 2022
@mergify mergify bot removed the has conflicts label Dec 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Dec 12, 2022
@carmocca carmocca enabled auto-merge (squash) December 12, 2022 14:38
@carmocca carmocca merged commit ed52823 into Lightning-AI:master Dec 12, 2022
@mauvilsa mauvilsa deleted the cli-optim-injection branch December 12, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants