-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LightningLite (2/n) #15938
Merged
Merged
Rename LightningLite (2/n) #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Dec 7, 2022
awaelchli
force-pushed
the
lite/debug-refactor-files
branch
from
December 7, 2022 13:52
b44fb82
to
0807b5e
Compare
awaelchli
commented
Dec 7, 2022
awaelchli
force-pushed
the
lite/debug-refactor-files
branch
from
December 7, 2022 13:54
7490066
to
b552cbe
Compare
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Dec 7, 2022
awaelchli
requested review from
carmocca,
justusschock,
Borda,
akihironitta,
williamFalcon and
tchaton
as code owners
December 7, 2022 14:22
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Dec 7, 2022
justusschock
approved these changes
Dec 7, 2022
Borda
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebranding 🎉
Follow up to #15932
Renames the
lightning_lite.lite
import.The next PR #15939 will rename the package.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda