-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax on_train_batch_*
hook check with dataloader_iter
to a warning
#16062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erhoo82
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
December 15, 2022 06:48
carmocca
reviewed
Dec 16, 2022
awaelchli
added
feature
Is an improvement or enhancement
community
This PR is from the community
labels
Dec 16, 2022
awaelchli
approved these changes
Dec 16, 2022
@carmocca |
carmocca
approved these changes
Jan 4, 2023
carmocca
changed the title
Change the check of on_train_batch hooks with
Relax Jan 4, 2023
dataloader_iter
from assert
to warn
on_train_batch_*
hook check with dataloader_iter
to a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the check of using
on_train_batch_start
andon_train_batch_end
hooks withdataloader_iter
fromassert
towarn
.When these hooks are used with
dataloader_iter
, thebatch_idx
argument would not match with the training index depending on how often the batch iteration is called per training step. So, this PR intends to raisewarning
on such behavior and let users use the training batch hooks for extensive use ofdataloader_iter
.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃