Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback support for Lite #16074

Merged
merged 10 commits into from
Dec 16, 2022

Conversation

lightningforever
Copy link
Contributor

@lightningforever lightningforever commented Dec 15, 2022

What does this PR do?

Arbitrary callbacks are now supported in Fabric. The user is responsible for invoking them, and fabric has a convenience method to trigger all callbacks at once for a given "event".

fabric = Fabric(callbacks=[callback0, callback1])
fabric.call("on_train_end")
fabric.call("on_batch_start", batch, batch_idx)  # arguments can be passed down as well

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli marked this pull request as ready for review December 15, 2022 15:20
src/lightning_fabric/fabric.py Show resolved Hide resolved
src/lightning_fabric/fabric.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 16, 2022
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just a naming proposal

src/lightning_fabric/fabric.py Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) December 16, 2022 15:07
@carmocca carmocca merged commit 33c95d9 into Lightning-AI:lite/debug Dec 16, 2022
@lightningforever lightningforever deleted the lite/debug-callback branch December 16, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants