Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Introduce basic auth to Lightning CLI #16105

Merged
merged 28 commits into from
Dec 22, 2022

Conversation

dmitsf
Copy link
Member

@dmitsf dmitsf commented Dec 18, 2022

What does this PR do?

Adds an opportunity to set up basic authentication for apps. The new option for running apps is --enable-basic-auth: its value should be a string in the format username:password:

lightning run app app.py --cloud --enable-basic-auth johndoe:qwerty

Limitations

BE/API PR that introduces lightning-cloud updates should be merged earlier. Therefore at the moment, CI is red for the PR: UPD: this was done.

Does your PR introduce any breaking changes? If yes, please list them.

No, it does not.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Dec 18, 2022
@dmitsf dmitsf self-assigned this Dec 18, 2022
@dmitsf dmitsf changed the title Introduce basic auth to Lightning CLI for app creation [App] Introduce basic auth to Lightning CLI Dec 19, 2022
@dmitsf dmitsf added the ready PRs ready to be merged label Dec 19, 2022
@mergify mergify bot removed the ready PRs ready to be merged label Dec 19, 2022
@dmitsf dmitsf marked this pull request as ready for review December 19, 2022 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success
app-pytest (macOS-11, app, 3.8, oldest) success
app-pytest (macOS-11, lightning, 3.9, latest) success
app-pytest (ubuntu-20.04, app, 3.8, latest) success
app-pytest (ubuntu-20.04, app, 3.8, oldest) success
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.8, oldest) success
app-pytest (windows-2022, lightning, 3.8, latest) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, tests/tests_app/cli/test_run_app.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_auth.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success
app-examples (macOS-11, app, 3.9, oldest) success
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, oldest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (windows-2022, app, 3.9, latest) success
app-examples (windows-2022, app, 3.9, oldest) success
app-examples (windows-2022, lightning, 3.9, latest) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success
make-html (app) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, lite, 3.7) success
install-pkg (ubuntu-22.04, lite, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, lite, 3.7) success
install-pkg (macOS-12, lite, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, lite, 3.7) success
install-pkg (windows-2022, lite, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@dmitsf dmitsf added the ready PRs ready to be merged label Dec 19, 2022
@mergify mergify bot removed the ready PRs ready to be merged label Dec 19, 2022
@dmitsf dmitsf added the ready PRs ready to be merged label Dec 19, 2022
@dmitsf dmitsf added this to the v1.8.x milestone Dec 19, 2022
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2022
src/lightning_app/cli/lightning_cli.py Outdated Show resolved Hide resolved
tests/tests_app/cli/test_run_app.py Outdated Show resolved Hide resolved
src/lightning_app/runners/runtime.py Outdated Show resolved Hide resolved
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Dec 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 22, 2022
@dmitsf dmitsf merged commit f08bc67 into master Dec 22, 2022
@dmitsf dmitsf deleted the ENG-2309-basic-auth-for-ozgurs-app branch December 22, 2022 18:07
carmocca pushed a commit that referenced this pull request Jan 3, 2023
* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests


* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule pushed a commit that referenced this pull request Jan 4, 2023
* [App] Introduce basic auth to Lightning CLI (#16105)

* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests


* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* docs: fix order of on_fit_start() hook (#16180)

Fixes #16170

* docs: updated broken links (#16191)

Co-authored-by: Shashwat <shashwat>
Fixes #16186

* Always use the local rank zero imports (#16178)

* update BYOC documentation with AWS details (#16044)

Co-authored-by: Adrian Wälchli <[email protected]>

* Using internal ip + port in a load balancer instead of URL exposed (#16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)

* simplify torch.Tensor (#16190)

* Fix inclusion of `model_parallel` document (#16197)

fix link to gpu/advanced section

* Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upload only with release (#16194)

* Update endpoint access examples: added info about accessing auth-protected apps (#16145)

* Skip a failing Bagua test for manual optimization (#16225)

* Fix type error when dividing chunk size in colossalai strategy (#16212)


Co-authored-by: awaelchli <[email protected]>

* Fix DDP on XLA (#16020)

Co-authored-by: awaelchli <[email protected]>

* Added support and test for custom artifact names in WandbLogger (#16173)

* Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improvements to checkpoint migration (#16233)

Co-authored-by: Justus Schock <[email protected]>

* Support arbitrary `Optimizable`s as optimizers (#16189)

* Differences with master

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitry Frolov <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: David Gilbertson <[email protected]>
Co-authored-by: Shashwat Agrawal <[email protected]>
Co-authored-by: Raphael Randschau <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HELSON <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Manan Goel <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
carmocca added a commit that referenced this pull request Jan 4, 2023
* [App] Introduce basic auth to Lightning CLI (#16105)

* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests


* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* docs: fix order of on_fit_start() hook (#16180)

Fixes #16170

* docs: updated broken links (#16191)

Co-authored-by: Shashwat <shashwat>
Fixes #16186

* Always use the local rank zero imports (#16178)

* update BYOC documentation with AWS details (#16044)

Co-authored-by: Adrian Wälchli <[email protected]>

* Using internal ip + port in a load balancer instead of URL exposed (#16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)

* simplify torch.Tensor (#16190)

* Fix inclusion of `model_parallel` document (#16197)

fix link to gpu/advanced section

* Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upload only with release (#16194)

* Update endpoint access examples: added info about accessing auth-protected apps (#16145)

* Skip a failing Bagua test for manual optimization (#16225)

* Fix type error when dividing chunk size in colossalai strategy (#16212)


Co-authored-by: awaelchli <[email protected]>

* Fix DDP on XLA (#16020)

Co-authored-by: awaelchli <[email protected]>

* Added support and test for custom artifact names in WandbLogger (#16173)

* Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improvements to checkpoint migration (#16233)

Co-authored-by: Justus Schock <[email protected]>

* Support arbitrary `Optimizable`s as optimizers (#16189)

* Differences with master

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitry Frolov <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: David Gilbertson <[email protected]>
Co-authored-by: Shashwat Agrawal <[email protected]>
Co-authored-by: Raphael Randschau <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HELSON <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Manan Goel <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
carmocca added a commit that referenced this pull request Jan 4, 2023
* [App] Introduce basic auth to Lightning CLI (#16105)

* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests

* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* docs: fix order of on_fit_start() hook (#16180)

Fixes #16170

* docs: updated broken links (#16191)

Co-authored-by: Shashwat <shashwat>
Fixes #16186

* Always use the local rank zero imports (#16178)

* update BYOC documentation with AWS details (#16044)

Co-authored-by: Adrian Wälchli <[email protected]>

* Using internal ip + port in a load balancer instead of URL exposed (#16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)

* simplify torch.Tensor (#16190)

* Fix inclusion of `model_parallel` document (#16197)

fix link to gpu/advanced section

* Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upload only with release (#16194)

* Update endpoint access examples: added info about accessing auth-protected apps (#16145)

* Skip a failing Bagua test for manual optimization (#16225)

* Fix type error when dividing chunk size in colossalai strategy (#16212)

Co-authored-by: awaelchli <[email protected]>

* Fix DDP on XLA (#16020)

Co-authored-by: awaelchli <[email protected]>

* Added support and test for custom artifact names in WandbLogger (#16173)

* Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improvements to checkpoint migration (#16233)

Co-authored-by: Justus Schock <[email protected]>

* Support arbitrary `Optimizable`s as optimizers (#16189)

* Differences with master

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitry Frolov <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: David Gilbertson <[email protected]>
Co-authored-by: Shashwat Agrawal <[email protected]>
Co-authored-by: Raphael Randschau <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HELSON <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Manan Goel <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants