Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Rename gradio.py gradio_server.py #16201

Merged
merged 13 commits into from
Jan 14, 2023
Merged

[App] Rename gradio.py gradio_server.py #16201

merged 13 commits into from
Jan 14, 2023

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 26, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes the error from running ServeGradio example on the cloud:

AttributeError: module 'gradio' has no attribute 'Interface'
full code and log on the cloud 
# !pip install gradio --no-cache-dir --upgrade
import lightning as L
import gradio as gr

class LitGradio(L.app.components.ServeGradio):

    inputs = gr.inputs.Textbox(default='lightning', label='name input')
    outputs = gr.outputs.Textbox(label='output')
    examples = [["hello lightning"]]

    def predict(self, input_text):
        return self.model(input_text)

    def build_model(self):
        fake_model = lambda x: f"hello {x}"
        return fake_model

class RootFlow(L.LightningFlow):
    def __init__(self):
        super().__init__()
        self.lit_gradio = LitGradio()

    def run(self):
        self.lit_gradio.run()

    def configure_layout(self):
        return [{"name": "home", "content": self.lit_gradio}]

app = L.LightningApp(RootFlow())
created virtual environment CPython3.8.10.final.0-64 in 2000ms
  creator CPython3Posix(dest=/content/venv, clear=False, no_vcs_ignore=False, global=True)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/zeus/.local/share/virtualenv)
    added seed packages: pip==22.3.1, setuptools==65.6.3, wheel==0.38.4
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
dependency cache not found
no dependency file given
no setup.py
lightning already installed
lightning-launcher already installed
+ echo Done
Done
 * Starting OpenBSD Secure Shell server sshd
   ...done.
/content/venv/lib/python3.8/site-packages/pkg_resources/__init__.py:123: PkgResourcesDeprecationWarning: 0.23ubuntu1 is an invalid version and will not be supported in a future release
  warnings.warn(
INFO: Running app setup command: pip install gradio --no-cache-dir --upgrade
Collecting gradio
  Downloading gradio-3.15.0-py3-none-any.whl (13.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 13.8/13.8 MB 175.9 MB/s eta 0:00:00
Requirement already satisfied: numpy in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (1.24.0)
Requirement already satisfied: uvicorn in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (0.20.0)
Requirement already satisfied: aiohttp in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (3.8.3)
Requirement already satisfied: pyyaml in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (6.0)
Collecting altair>=4.2.0
  Downloading altair-4.2.0-py3-none-any.whl (812 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 812.8/812.8 kB 207.2 MB/s eta 0:00:00
Requirement already satisfied: fsspec in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (2022.11.0)
Requirement already satisfied: orjson in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (3.8.3)
Requirement already satisfied: requests in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (2.28.1)
Requirement already satisfied: fastapi in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (0.88.0)
Requirement already satisfied: jinja2 in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (3.1.2)
Requirement already satisfied: markupsafe in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (2.1.1)
Collecting matplotlib
  Downloading matplotlib-3.6.2-cp38-cp38-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (9.4 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 9.4/9.4 MB 146.2 MB/s eta 0:00:00
Requirement already satisfied: websockets>=10.0 in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (10.4)
Requirement already satisfied: python-multipart in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (0.0.5)
Collecting pycryptodome
  Downloading pycryptodome-3.16.0-cp35-abi3-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (2.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 158.9 MB/s eta 0:00:00
Collecting ffmpy
  Downloading ffmpy-0.3.0.tar.gz (4.8 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Requirement already satisfied: httpx in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (0.23.1)
Collecting pydub
  Downloading pydub-0.25.1-py2.py3-none-any.whl (32 kB)
Collecting pillow
  Downloading Pillow-9.3.0-cp38-cp38-manylinux_2_28_x86_64.whl (3.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.3/3.3 MB 120.0 MB/s eta 0:00:00
Requirement already satisfied: pydantic in /home/zeus/.local/lib/python3.8/site-packages (from gradio) (1.10.2)
Collecting pandas
  Downloading pandas-1.5.2-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (12.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.2/12.2 MB 87.5 MB/s eta 0:00:00
Collecting markdown-it-py[linkify,plugins]
  Downloading markdown_it_py-2.1.0-py3-none-any.whl (84 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 84.5/84.5 kB 162.3 MB/s eta 0:00:00
Collecting entrypoints
  Downloading entrypoints-0.4-py3-none-any.whl (5.3 kB)
Collecting toolz
  Downloading toolz-0.12.0-py3-none-any.whl (55 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 55.8/55.8 kB 166.8 MB/s eta 0:00:00
Collecting jsonschema>=3.0
  Downloading jsonschema-4.17.3-py3-none-any.whl (90 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 90.4/90.4 kB 188.9 MB/s eta 0:00:00
Collecting pytz>=2020.1
  Downloading pytz-2022.7-py2.py3-none-any.whl (499 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 499.4/499.4 kB 217.7 MB/s eta 0:00:00
Requirement already satisfied: python-dateutil>=2.8.1 in /home/zeus/.local/lib/python3.8/site-packages (from pandas->gradio) (2.8.2)
Requirement already satisfied: charset-normalizer<3.0,>=2.0 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (2.1.1)
Requirement already satisfied: aiosignal>=1.1.2 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (1.3.1)
Requirement already satisfied: frozenlist>=1.1.1 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (1.3.3)
Requirement already satisfied: multidict<7.0,>=4.5 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (6.0.3)
Requirement already satisfied: attrs>=17.3.0 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (22.2.0)
Requirement already satisfied: async-timeout<5.0,>=4.0.0a3 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (4.0.2)
Requirement already satisfied: yarl<2.0,>=1.0 in /home/zeus/.local/lib/python3.8/site-packages (from aiohttp->gradio) (1.8.2)
Requirement already satisfied: starlette==0.22.0 in /home/zeus/.local/lib/python3.8/site-packages (from fastapi->gradio) (0.22.0)
Requirement already satisfied: typing-extensions>=3.10.0 in /home/zeus/.local/lib/python3.8/site-packages (from starlette==0.22.0->fastapi->gradio) (4.4.0)
Requirement already satisfied: anyio<5,>=3.4.0 in /home/zeus/.local/lib/python3.8/site-packages (from starlette==0.22.0->fastapi->gradio) (3.6.2)
Requirement already satisfied: certifi in /usr/lib/python3/dist-packages (from httpx->gradio) (2019.11.28)
Requirement already satisfied: httpcore<0.17.0,>=0.15.0 in /home/zeus/.local/lib/python3.8/site-packages (from httpx->gradio) (0.16.3)
Requirement already satisfied: sniffio in /home/zeus/.local/lib/python3.8/site-packages (from httpx->gradio) (1.3.0)
Requirement already satisfied: rfc3986[idna2008]<2,>=1.3 in /home/zeus/.local/lib/python3.8/site-packages (from httpx->gradio) (1.5.0)
Collecting mdurl~=0.1
  Downloading mdurl-0.1.2-py3-none-any.whl (10.0 kB)
Collecting linkify-it-py~=1.0
  Downloading linkify_it_py-1.0.3-py3-none-any.whl (19 kB)
Collecting mdit-py-plugins
  Downloading mdit_py_plugins-0.3.3-py3-none-any.whl (50 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 50.5/50.5 kB 168.5 MB/s eta 0:00:00
Collecting contourpy>=1.0.1
  Downloading contourpy-1.0.6-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (295 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 296.0/296.0 kB 215.9 MB/s eta 0:00:00
Collecting fonttools>=4.22.0
  Downloading fonttools-4.38.0-py3-none-any.whl (965 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 965.4/965.4 kB 207.5 MB/s eta 0:00:00
Requirement already satisfied: packaging>=20.0 in /home/zeus/.local/lib/python3.8/site-packages (from matplotlib->gradio) (22.0)
Collecting pyparsing>=2.2.1
  Downloading pyparsing-3.0.9-py3-none-any.whl (98 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 98.3/98.3 kB 169.4 MB/s eta 0:00:00
Collecting cycler>=0.10
  Downloading cycler-0.11.0-py3-none-any.whl (6.4 kB)
Collecting kiwisolver>=1.0.1
  Downloading kiwisolver-1.4.4-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 211.0 MB/s eta 0:00:00
Requirement already satisfied: six>=1.4.0 in /usr/lib/python3/dist-packages (from python-multipart->gradio) (1.14.0)
Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3/dist-packages (from requests->gradio) (2.8)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/zeus/.local/lib/python3.8/site-packages (from requests->gradio) (1.26.13)
Requirement already satisfied: h11>=0.8 in /home/zeus/.local/lib/python3.8/site-packages (from uvicorn->gradio) (0.14.0)
Requirement already satisfied: click>=7.0 in /home/zeus/.local/lib/python3.8/site-packages (from uvicorn->gradio) (8.1.3)
Collecting pkgutil-resolve-name>=1.3.10
  Downloading pkgutil_resolve_name-1.3.10-py3-none-any.whl (4.7 kB)
Requirement already satisfied: importlib-resources>=1.4.0 in /home/zeus/.local/lib/python3.8/site-packages (from jsonschema>=3.0->altair>=4.2.0->gradio) (5.10.1)
Collecting pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0
  Downloading pyrsistent-0.19.2-py3-none-any.whl (57 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 57.5/57.5 kB 151.3 MB/s eta 0:00:00
Collecting uc-micro-py
  Downloading uc_micro_py-1.0.1-py3-none-any.whl (6.2 kB)
Requirement already satisfied: zipp>=3.1.0 in /home/zeus/.local/lib/python3.8/site-packages (from importlib-resources>=1.4.0->jsonschema>=3.0->altair>=4.2.0->gradio) (3.11.0)
Building wheels for collected packages: ffmpy
  Building wheel for ffmpy (setup.py): started
  Building wheel for ffmpy (setup.py): finished with status 'done'
  Created wheel for ffmpy: filename=ffmpy-0.3.0-py3-none-any.whl size=4693 sha256=84d1c22448c5f9d8361f32042a65d423842374eadc85dbd4e6eceedafd85a3ed
  Stored in directory: /tmp/pip-ephem-wheel-cache-x7g1jomw/wheels/c7/a7/3e/a6b4408a53b4de8176071a885ed909562c2e4e9422ef7622fe
Successfully built ffmpy
Installing collected packages: pytz, pydub, ffmpy, uc-micro-py, toolz, pyrsistent, pyparsing, pycryptodome, pkgutil-resolve-name, pillow, mdurl, kiwisolver, fonttools, entrypoints, cycler, contourpy, pandas, matplotlib, markdown-it-py, linkify-it-py, jsonschema, mdit-py-plugins, altair, gradio
Successfully installed altair-4.2.0 contourpy-1.0.6 cycler-0.11.0 entrypoints-0.4 ffmpy-0.3.0 fonttools-4.38.0 gradio-3.15.0 jsonschema-4.17.3 kiwisolver-1.4.4 linkify-it-py-1.0.3 markdown-it-py-2.1.0 matplotlib-3.6.2 mdit-py-plugins-0.3.3 mdurl-0.1.2 pandas-1.5.2 pillow-9.3.0 pkgutil-resolve-name-1.3.10 pycryptodome-3.16.0 pydub-0.25.1 pyparsing-3.0.9 pyrsistent-0.19.2 pytz-2022.7 toolz-0.12.0 uc-micro-py-1.0.1
/content/venv/lib/python3.8/site-packages/gradio/inputs.py:26: UserWarning: Usage of gradio.inputs is deprecated, and will not be supported in the future, please import your component from gradio.components
  warnings.warn(
/content/venv/lib/python3.8/site-packages/gradio/deprecation.py:40: UserWarning: `optional` parameter is deprecated, and it has no effect
  warnings.warn(value)
/content/venv/lib/python3.8/site-packages/gradio/deprecation.py:40: UserWarning: `numeric` parameter is deprecated, and it has no effect
  warnings.warn(value)
/content/venv/lib/python3.8/site-packages/gradio/outputs.py:21: UserWarning: Usage of gradio.outputs is deprecated, and will not be supported in the future, please import your components from gradio.components
  warnings.warn(
Traceback (most recent call last):
    sys.exit(main())
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/zeus/.local/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning_launcher/cli/__main__.py", line 87, in run_work
    run_lightning_work(
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning_launcher/utils.py", line 50, in wrapper
    res = func(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning_launcher/utils.py", line 75, in wrapper
    res = func(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning_launcher/launcher.py", line 181, in run_lightning_work
    WorkRunner(
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/utilities/proxies.py", line 419, in __call__
    raise e
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/utilities/proxies.py", line 402, in __call__
    self.run_once()
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/utilities/proxies.py", line 550, in run_once
    self.work.on_exception(e)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/core/work.py", line 612, in on_exception
    raise exception
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/utilities/proxies.py", line 515, in run_once
    ret = self.run_executor_cls(self.work, work_run, self.delta_queue)(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/utilities/proxies.py", line 351, in __call__
    return self.work_run(*args, **kwargs)
  File "/home/zeus/.local/lib/python3.8/site-packages/lightning/app/components/serve/gradio.py", line 68, in run
    gradio.Interface(
AttributeError: module 'gradio' has no attribute 'Interface'

Does your PR introduce any breaking changes? If yes, please list them.

Changes one of the import statements as follows:

import lightning.app.components import ServeGradio
import lightning.app.components.serve import ServeGradio
-import lightning.app.components.serve.gradio import ServeGradio
+import lightning.app.components.serve.gradio_server import ServeGradio

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Additional info

For people who have access to app info: https://lightning.ai/akihiro/apps/01gn6awsyesn0t9p84twcfb0r4

cc @Borda

@akihironitta akihironitta added bug Something isn't working app (removed) Generic label for Lightning App package components labels Dec 26, 2022
@akihironitta akihironitta added this to the v1.8.x milestone Dec 26, 2022
@akihironitta akihironitta self-assigned this Dec 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py, tests/integrations_app/public/test_gradio.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py, tests/integrations_app/public/test_gradio.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py, docs/source-app/api_reference/components.rst, docs/source-app/api_references.rst.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning_app/components/__init__.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/gradio_server.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@akihironitta akihironitta changed the title [App] Rename gradio.py to gradio_server.py [App] Rename gradio.py gradio_server.py Dec 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Dec 26, 2022
@Borda Borda enabled auto-merge (squash) December 28, 2022 10:44
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jan 4, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jan 5, 2023
@Borda Borda removed this from the v1.8.x milestone Jan 6, 2023
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jan 10, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jan 12, 2023
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jan 12, 2023
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Jan 12, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jan 13, 2023
@Borda Borda requested a review from carmocca as a code owner January 13, 2023 07:29
@Borda Borda merged commit fa73327 into master Jan 14, 2023
@Borda Borda deleted the bugfix/import-gradio branch January 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@akihironitta akihironitta

Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@akihironitta @awaelchli @Borda @tchaton