Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LR step scheduler to use total step to work across epochs #20248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

falckt
Copy link

@falckt falckt commented Sep 5, 2024

What does this PR do?

Fixes #17544

I am not sure whether to consider this as a breaking change. For frequencies > epoch length I would consider it a bug fix. For frequencies < epoch length it does change the behavior but IMHO not in a fundamental way and personally I expected the new behavior to begin with.

Before submitting
  • Was this discussed/agreed via a GitHub issue? change according to @awaelchli suggestion in Stepwise LR-Scheduler not working across epochs  #17544 (comment)

  • Did you read the contributor guideline, Pull Request section?

  • Did you make sure your PR does only one thing, instead of bundling different changes together?

  • Did you make sure to update the documentation with your changes?

    I don't think it is necessary, I would consider the new behavior the expected one.

  • Did you write any new necessary tests?

    I couldn't find any tests for the old code. Q: does this need a test?

  • Did you verify new and existing tests pass locally with your changes? it works as expected locally

  • Did you list all the breaking changes introduced by this pull request? yes

  • Did you update the CHANGELOG? todo

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20248.org.readthedocs.build/en/20248/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 5, 2024
@falckt falckt marked this pull request as ready for review September 5, 2024 13:33
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (474bdd0) to head (fd1883f).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (474bdd0) and HEAD (fd1883f). Click for more details.

HEAD has 87 uploads less than BASE
Flag BASE (474bdd0) HEAD (fd1883f)
cpu 41 21
python3.10 12 6
lightning_fabric 7 0
pytest 25 2
lightning 31 16
python3.9 11 6
gpu 4 2
python3.11 12 6
python3.12 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20248     +/-   ##
=========================================
- Coverage      89%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23064    23009     -55     
=========================================
- Hits        20573    18606   -1967     
- Misses       2491     4403   +1912     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepwise LR-Scheduler not working across epochs
2 participants