-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newmetric: ProcrustesDisparity
#2723
base: master
Are you sure you want to change the base?
Conversation
ProcrustesDisparity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2723 +/- ##
======================================
Coverage 69% 69%
======================================
Files 329 334 +5
Lines 18077 18143 +66
======================================
+ Hits 12499 12557 +58
- Misses 5578 5586 +8 |
|
||
|
||
def procrustes_disparity( | ||
dataset1: Tensor, dataset2: Tensor, return_all: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering if we should rename the arguments from dataset
but not sure about a better name...
|
||
The metric works similar to `scipy.spatial.procrustes` but for batches of data points. The disparity is | ||
aggregated over the batch, thus to get the individual disparities please use the functional version of this | ||
metric: ``torchmetrics.functional.shape.procrustes.procrustes_disparity``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this single of `?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I mean shall it be rather cross-ref then just plain code?
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
26ab893
to
5e771da
Compare
What does this PR do?
Fixes #2691
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2723.org.readthedocs.build/en/2723/