Newmetric: ProcrustesDisparity
#2723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
github-actions
bot
added
the
documentation
SkafteNicki
changed the title
ProcrustesDisparity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2723 +/- ##
======================================
Coverage 69% 69%
======================================
Files 329 334 +5
Lines 18077 18143 +66
======================================
+ Hits 12499 12557 +58
- Misses 5578 5586 +8 |
Borda
reviewed
Sep 9, 2024
|
|
||
|
|
||
| def procrustes_disparity( | ||
| dataset1: Tensor, dataset2: Tensor, return_all: bool = False |
There was a problem hiding this comment.
just wondering if we should rename the arguments from dataset but not sure about a better name...
|
|
||
| The metric works similar to `scipy.spatial.procrustes` but for batches of data points. The disparity is | ||
| aggregated over the batch, thus to get the individual disparities please use the functional version of this | ||
| metric: ``torchmetrics.functional.shape.procrustes.procrustes_disparity``. |
There was a problem hiding this comment.
well I mean shall it be rather cross-ref then just plain code?
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Borda
force-pushed
the
newmetric/procrustes
branch
from
26ab893
to
5e771da
Compare
Borda
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2691
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2723.org.readthedocs.build/en/2723/