Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow for PSNR metric when used with uint8 input #2788

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 18, 2024

What does this PR do?

Fixes #2787

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2788.org.readthedocs.build/en/2788/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Oct 18, 2024
@SkafteNicki SkafteNicki added this to the v1.4.x milestone Oct 18, 2024
@SkafteNicki SkafteNicki self-assigned this Oct 18, 2024
@mergify mergify bot removed the has conflicts label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38%. Comparing base (6377aa5) to head (e86c101).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6377aa5) and HEAD (e86c101). Click for more details.

HEAD has 240 uploads less than BASE
Flag BASE (6377aa5) HEAD (e86c101)
Windows 12 3
python3.8 12 3
cpu 80 20
torch1.13.1+cpu 12 3
macOS 16 4
python3.10 20 5
torch2.0.1 8 2
torch2.4.0+cpu 4 1
python3.11 12 3
torch1.12.1+cpu 4 1
Linux 52 13
python3.9 36 9
torch2.4.0 4 1
torch1.10.2+cpu 4 1
torch2.0.1+cpu 12 3
torch1.11.0+cpu 4 1
torch2.3.1+cpu 8 2
torch1.13.1 4 1
torch2.2.2+cpu 8 2
torch2.1.2+cpu 4 1
torch2.4.0+cu121 4 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2788     +/-   ##
========================================
- Coverage      70%     38%    -32%     
========================================
  Files         336     336             
  Lines       18231   18235      +4     
========================================
- Hits        12707    6913   -5794     
- Misses       5524   11322   +5798     

@Borda Borda merged commit 0fd1f96 into master Oct 18, 2024
59 of 62 checks passed
@Borda Borda deleted the bugfix/psnr_dtype branch October 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect PSNR for uint8 images
2 participants