Skip to content

Commit

Permalink
test: remove error allowance in debugger test
Browse files Browse the repository at this point in the history
Remove allowance for FATAL ERROR. It is no longer needed.

PR-URL: nodejs#41640
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
  • Loading branch information
MrJithil authored and Linkgoron committed Jan 31, 2022
1 parent 0192c02 commit 34246e6
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions test/sequential/test-debugger-exceptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ const path = require('path');
})
// Making sure it will die by default:
.then(() => cli.command('c'))
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore.
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))
.then(() => cli.waitFor(/disconnect/))

// Next run: With `breakOnException` it pauses in both places.
.then(() => cli.stepCommand('r'))
Expand Down Expand Up @@ -66,9 +65,7 @@ const path = require('path');
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
})
.then(() => cli.command('c'))
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))

.then(() => cli.waitFor(/disconnect/))
.then(() => cli.quit())
.then(null, onFatal);
}

0 comments on commit 34246e6

Please sign in to comment.