Update for July decisions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ make qualifiedName and allFeatures external to M3Node + Refactor here and there + organize imports throughout
+ add a pretty-printer to textual format (for easier visual comparison) + various Refactorings
* serializer now generates meaningful meta-pointers and used language dependencies * added Node and INamed to LIonCore-builtins, and fixed keys -- serialization now matches the Java one * numerous Refactorings * implement a “shortener” for the JSON serialization format, for easier visual comparison
* implement sorting of JSON serialization for easier comparison
* add a CLI util to generate "extractions" * Refactor type name SerializationModel -> SerializationChunk
|
I am not skilled enough with TS to provide a proper review, but I could not see anything immediately wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing is that serialization of LIonCore self-definition and builtins (stdlib) should now match the Java one.
(no Annotations yet)