Fix multi-language models #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dslmeinte
requested review from
ftomassetti,
joswarmer,
indamutsa and
woppa684
dslmeinte
force-pushed
the
fix/multi-language-models
branch
from
e7a727d
to
60b3a06
Compare
|
(Rebased this on |
dslmeinte
force-pushed
the
fix/multi-language-models
branch
from
60b3a06
to
e290709
Compare
* Minimal example of failing multi-lang deserialziing * Small typo --------- Co-authored-by: Roel van Bakel <[email protected]>
dslmeinte
force-pushed
the
fix/multi-language-models
branch
from
e290709
to
2fd4b6d
Compare
|
@woppa684 @joswarmer @indamutsa Do you want to have a look at this still? Otherwise I'll just merge. |
I am going to have a look now... |
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
src-test/multi.ts
Outdated
There was a problem hiding this comment.
I think I can comment by code blocks to facilitate new collaborators...
There was a problem hiding this comment.
You want to add a commit to this PR with your comments?
There was a problem hiding this comment.
OK, I'm going to merge this PR now. Could you make a separate PR with the additional comments that you think would help new collaborators?
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
indamutsa
reviewed
Sep 14, 2023
+ reorganize models/ into "languages" vs. "instances" + reorganize src-test to align with models/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #61