-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-language models #63
Conversation
e7a727d
to
60b3a06
Compare
(Rebased this on |
60b3a06
to
e290709
Compare
* Minimal example of failing multi-lang deserialziing * Small typo --------- Co-authored-by: Roel van Bakel <[email protected]>
e290709
to
2fd4b6d
Compare
@woppa684 @joswarmer @indamutsa Do you want to have a look at this still? Otherwise I'll just merge. |
I am going to have a look now... |
src-test/multi.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can comment by code blocks to facilitate new collaborators...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to add a commit to this PR with your comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm going to merge this PR now. Could you make a separate PR with the additional comments that you think would help new collaborators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left my reviews as single comments...
+ reorganize models/ into "languages" vs. "instances" + reorganize src-test to align with models/
Fixes issue #61