Fix gazebo_ros/node.hpp not found issue when building uuv_gazebo_ros_plugins #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Plankton authors,
Thanks for the great work on this project. I'm sure many developers of/using
uuv_simulator
would find Plankton useful in a ROS2 environment.Re: this pull request, I noticed the issue attached in the image below when building Plankton via
colcon build --packages-up-to plankton
. I believe the inclusion ofgazebo_dev
package dependency alone isn't enough to make CMake/Ament includegazebo_ros
headers that the packageuuv_gazebo_ros_plugins
depends on. This pull-request addresses this issue by includinggazebo_ros
in the package's CMakeLists.txt, which lets the package to build with appropriate includes from say/opt/ros/foxy/include/gazebo_ros
.Let me know what you think.
System environment details:
OS: Ubuntu 20.04
ROS2 version: Foxy
Gazebo version: 11
Cheers.
Ashish