Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run a node Process after invoking raw V8 #3

Closed
ericwlange opened this issue Dec 5, 2016 · 1 comment
Closed

Can't run a node Process after invoking raw V8 #3

ericwlange opened this issue Dec 5, 2016 · 1 comment

Comments

@ericwlange
Copy link
Member

Node requires some flags to be set prior to calling V8::Initialize(). If you start by running a node process and then subsequently create some contexts using raw v8, everything works fine. If you swap the order, the app will crash on node initialization.
@ericwlange ericwlange self-assigned this Dec 5, 2016
ericwlange added a commit that referenced this issue Dec 7, 2016
@ericwlange
Fixed issue [#6 instanceof regression]
cb91b46 
- Java side handled prototypes incorrectly, test was also incorrect -- fixed
- Added a default constructor for NodeInstance() in an attempt to find a fix for issue [#3], doesn't fix the problem yet
- Removed commented out code
- Moved prototype functions back from JSFunction to JSObject where they belong
ericwlange added a commit that referenced this issue Dec 7, 2016
@ericwlange
Fixed [#3 Can't run a node Process after invoking raw V8]
36bdaad 
Replaced usage of `v8::Lock` with `std::recursive_mutex`.  Once a v8 lock is
used, v8 requires it to be used everywhere, even in a separate isolate.  Since
node.js uses a single thread, it does not implement locking.  So if a lock is
introduced, node will crash.  We get the same value from `std::recursive_mutex`
so we use that instead.  Removed hack call of `NodeInstance init` as it has no
effect.
@ericwlange
Copy link
Member Author

Fixed in 36bdaad81e22b2bd466905e3b7ac84b8c8b1f0aa

@ericwlange ericwlange mentioned this issue Dec 7, 2016
Closed
@charles-b-stb charles-b-stb mentioned this issue Feb 28, 2017
Closed
@ericwlange ericwlange removed their assignment Feb 25, 2019
@alexanderzhigulich alexanderzhigulich mentioned this issue Apr 16, 2019
Closed
@cashdow cashdow mentioned this issue Nov 20, 2019
Closed
@carlosjrtee carlosjrtee mentioned this issue Aug 10, 2020
Open
@carlosjrtee carlosjrtee mentioned this issue Sep 14, 2020
Open
@rabinhod rabinhod mentioned this issue Nov 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericwlange