Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application tag in Mainfest interferes with application Manifest #79

Closed
baruchn opened this issue Jan 23, 2019 · 2 comments
Closed

Application tag in Mainfest interferes with application Manifest #79

baruchn opened this issue Jan 23, 2019 · 2 comments

Comments

@baruchn
Copy link

baruchn commented Jan 23, 2019

If an Android application is using LiquidCoreAndroid with a configuration of allowBackup=false or supportsRtl=false it will get an error because of contradicting values in the Manufest of LiquidCore.
I don't believe that the <application> tag is necessary for a library and should probably be removed.
@ericwlange ericwlange self-assigned this Jan 23, 2019
@ericwlange
Copy link
Member

Agreed -- will remove it. Thanks for reporting.

ericwlange added a commit that referenced this issue Jan 24, 2019
@ericwlange
Removed LiquidView, node-sqlite3, ConsoleSurface, NodeConsole and all…
ee0e82a 
… dependencies

These are being moved to their own repos as addons
Fixed hack where dummy .node files are created in /home/temp
Re-use /home/node_modules to house .node files, removed everything else
Fixed issue #79
Fixed all javadoc errors/warnings
@ericwlange
Copy link
Member

This is fixed in v0.6.0. The <application> tag was added so the instrumentation tests could use HTTP (not HTTPS) for testing. I moved this to the androidTest/AndroidManifest.xml.

@ericwlange ericwlange removed their assignment Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericwlange @baruchn