Merge pull request #6086 from LiskHQ/6083-npm-install

Failure in package installation during bootstrapping is not detected - Closes #6083
LiskArchive · Jan 21, 2021 · 235fe9d · 235fe9d
2 parents 1ef0b2f + a3a0d92
commit 235fe9d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/commander/src/bootstrapping/env.ts b/commander/src/bootstrapping/env.ts
@@ -18,6 +18,6 @@ import yeoman from 'yeoman-environment';
 
 const env = yeoman.createEnv();
 
-env.register(require.resolve('./generators/init'), 'lisk:init');
+env.register(require.resolve('./generators/init_generator'), 'lisk:init');
 
 export { env };
diff --git a/...nder/src/bootstrapping/generators/init.ts → ...ootstrapping/generators/init_generator.ts b/...nder/src/bootstrapping/generators/init.ts → ...ootstrapping/generators/init_generator.ts
@@ -35,16 +35,18 @@ export default class InitGenerator extends BootstrapGenerator {
 	}
 
 	public install(): void {
+		this.log('\n');
 		this.log('Initializing git repository');
 		this.composeWith(require.resolve('generator-git-init'));
 
-		this.log('Installing npm packages');
-		this.npmInstall();
+		this.log('\n');
+		this.log(
+			'After completion of npm installation run below command to start your blockchain app.\n',
+		);
+		this.log(`cd ${this.destinationRoot()}; npm start`);
 	}
 
 	public end(): void {
-		this.log('\n\n');
-		this.log('All set! Run below command to start your blockchain app.\n');
-		this.log(`cd ${this.destinationRoot()}; npm start`);
+		this.installDependencies({ npm: true, bower: false, yarn: false, skipMessage: false });
 	}
 }
diff --git a/commander/src/bootstrapping/templates/lisk-template-ts/templates/app/package.json b/commander/src/bootstrapping/templates/lisk-template-ts/templates/app/package.json
@@ -14,8 +14,8 @@
 	"homepage": "",
 	"repository": {},
 	"engines": {
-		"node": ">=12.20.1",
-		"npm": ">=6.14.10"
+		"node": ">=12.13.0 <=12",
+		"npm": ">=6.12.0"
 	},
 	"main": "dist/index.js",
 	"scripts": {