Merge pull request #3829 from LiskHQ/3368-remove_code_in_cleanup_chain

Remove unnecessary argument code from cleanup - Closes #3368
LiskArchive · Jun 18, 2019 · cc55b7c · cc55b7c
2 parents f8b5d48 + 80bc241
commit cc55b7c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/framework/src/modules/chain/chain.js b/framework/src/modules/chain/chain.js
@@ -260,16 +260,11 @@ module.exports = class Chain {
 		};
 	}
 
-	async cleanup(code, error) {
+	async cleanup(error) {
 		this._unsubscribeToEvents();
 		const { modules, components } = this.scope;
 		if (error) {
 			this.logger.fatal(error.toString());
-			if (code === undefined) {
-				code = 1;
-			}
-		} else if (code === undefined || code === null) {
-			code = 0;
 		}
 		this.logger.info('Cleaning chain...');
 

diff --git a/framework/src/modules/chain/index.js b/framework/src/modules/chain/index.js
@@ -140,6 +140,6 @@ module.exports = class ChainModule extends BaseModule {
 	}
 
 	async unload() {
-		return this.chain.cleanup(0);
+		return this.chain.cleanup();
 	}
 };