This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
Change the API response to return an array of errors #3152
Milestone
Comments
shuse2
modified the milestones:
Improve transaction processing efficiency,
Improve Transaction Processing Efficiency - Phase 2
Mar 26, 2019
We should also check |
We should fix any tests tagged with |
Yes that's fixed in the branch I'm working on. I am in the process of updating tests. |
@mitsujutsu be aware that PR #3268 fixes integration and some unit tests so you should check that branch (is about to be merged tough) |
@pablitovicente Ok I am currently working on functional tests so that should not be an issue. |
SargeKhan
pushed a commit
that referenced
this issue
Apr 23, 2019
Fix functional and unit tests - Closes #3152
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
The API response should return all the errors encountered when processing a request. Therefore, the structure of the API response should be:
Actual behavior
The structure of API response in case of an error is not very extensible. It contains only one property with the name
message
which is of type string. In cases where there are multiple errors, it is impossible to return all the errors in this format. The current structure of the API response in case of an error is as follow:Which version(s) does this affect? (Environment, OS, etc...)
1.7
The text was updated successfully, but these errors were encountered: