Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Functional WS tests constantly failing #3607

Closed
pablitovicente opened this issue May 14, 2019 · 3 comments · Fixed by #3843
Closed

Functional WS tests constantly failing #3607

pablitovicente opened this issue May 14, 2019 · 3 comments · Fixed by #3843

Comments

@pablitovicente
Copy link
Contributor

Expected behavior

  • Functional WS tests do not fail

Actual behavior

  • Functional WS tests constantly fail with
[2019-05-14T08:23:55.073Z]      TimeoutError: Event response for 'rpc-request' timed out

[2019-05-14T08:23:55.073Z]       at SCClientSocket._handleEventAckTimeout (/home/lisk/workspace/lisk-sdk-framework_PR-3603/node_modules/socketcluster-client/lib/scclientsocket.js:700:17)

[2019-05-14T08:23:55.073Z]       at Timeout._onTimeout (/home/lisk/workspace/lisk-sdk-framework_PR-3603/node_modules/socketcluster-client/lib/scclientsocket.js:730:10)

Steps to reproduce

  • Check any ongoing PR
  • This behaviour is more common in Jenkins than locally but it does happen locally too with less frequency

Which version(s) does this affect? (Environment, OS, etc...)

@shuse2
Copy link
Collaborator

shuse2 commented Jun 4, 2019

Development branch seems to be stable now, so closing this issue for now

@shuse2 shuse2 closed this as completed Jun 4, 2019
@shuse2 shuse2 reopened this Jun 4, 2019
@shuse2 shuse2 added this to the Technical Debt - Sprint 1 milestone Jun 13, 2019
@pablitovicente pablitovicente self-assigned this Jun 13, 2019
@pablitovicente
Copy link
Contributor Author

Initial investigation might suggest that when the node running the tests is under heavy load the ws tests are failing; the behaviour is random so still investigating how to solve.

@pablitovicente
Copy link
Contributor Author

Information gathered about this issue:

  • Although the error thrown by P2P seems to imply that the connection is dropped it's actually NOT open; for testing this I added debug points to socket cluster and when the failure occurs the connection is never made to the node

  • The only way to reproduce this is to load all cores of the CPU to the max and then run the WS tests until they fail;

It's important to note that this only happens when running tests and the SDK is not actually affected by this issue.

Leaving issue open for more research in the future.

@lsilvs lsilvs self-assigned this Jun 20, 2019
shuse2 added a commit that referenced this issue Jun 20, 2019
Functional WS tests constantly failing - Closes #3607
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.