Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Combine all the transaction related logic into one module and expose used functionality #3614

Closed
shuse2 opened this issue May 14, 2019 · 1 comment · Fixed by #3620
Closed

Combine all the transaction related logic into one module and expose used functionality #3614

shuse2 opened this issue May 14, 2019 · 1 comment · Fixed by #3620
Assignees
@shuse2
Labels
type: refactoring

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 14, 2019

Expected behavior

Within transactions module, it should not have any external dependency, and only exposing the used function from other module

  • init_transaction.js
  • process_transaction.js
  • check_transaction_against_exceptions.js
  • broadcaster.js
  • transaction_pool.js
  • transactions.js
  • process_transactions.js
  • multisignatures.js

Actual behavior

Transaction logic spread across the chain module
@pablitovicente
Copy link
Contributor

Before starting work on this we should merge #3501

@shuse2 shuse2 mentioned this issue May 14, 2019
Merged
shuse2 added a commit that referenced this issue May 24, 2019
@shuse2
Merge pull request #3620 from LiskHQ/3614-fix_transaction_related_dep…
6899965 
…endency

Fix transaction related dependency - Closes #3614
This was referenced May 28, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix transaction related dependency - Closes #3614 LiskArchive/lisk-sdk
2 participants
@pablitovicente @shuse2