Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove bus from chain module #3813

Closed
shuse2 opened this issue Jun 12, 2019 · 1 comment · Fixed by #3840
Closed

Remove bus from chain module #3813

shuse2 opened this issue Jun 12, 2019 · 1 comment · Fixed by #3840
Assignees

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Jun 12, 2019

Expected behavior

Since we introduced the new architecture supporting the inter-module communication through the channels, we should use them to facilitate the interactions within the chain modules itself.

Actual behavior

To communicate between modules we use the bus (as a helper).

Steps to reproduce

  • the bus helper is removed
  • the bus usages are replaced by channel.invoke calls

Which version(s) does this affect? (Environment, OS, etc...)

*

@lsilvs
Copy link
Contributor

lsilvs commented Jun 13, 2019

Also, consider replacing the use of EventEmitter as extended class.

Current extended by:

framework/src/modules/chain/blocks/blocks.js
framework/src/modules/chain/transaction_pool/transaction_pool.js

@lsilvs lsilvs self-assigned this Jun 19, 2019
shuse2 added a commit that referenced this issue Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants