Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Sequence should not be used in Loader #3977

Closed
pablitovicente opened this issue Jul 17, 2019 · 1 comment
Closed

Sequence should not be used in Loader #3977

pablitovicente opened this issue Jul 17, 2019 · 1 comment

Comments

@pablitovicente
Copy link
Contributor

Expected behavior

sequence is a property of loader

Actual behavior

sequence is not a property of loader causing an error on startup

    Unconfirmed transactions loader Error: [object Object]
        at /Users/pablo/Documents/LISK/Repos/lisk-sdk/node_modules/async/dist/async.js:205:62
        at process._tickCallback (internal/process/next_tick.js:68:7)
[2019-07-17T15:03:36.259Z]  INFO: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:178 in _getSignaturesFromNetwork): Loading signatures from the network
[2019-07-17T15:03:36.260Z] DEBUG: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/rounds/delegates.js:230 in updateDelegateListCache): Updating delegate list cache for round 1
[2019-07-17T15:03:36.262Z]  INFO: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:178 in _getSignaturesFromNetwork): Loading signatures from the network
[2019-07-17T15:03:36.264Z]  INFO: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:178 in _getSignaturesFromNetwork): Loading signatures from the network
[2019-07-17T15:03:36.264Z] DEBUG: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/rounds/rounds.js:208 in Tick): Performing forward tick
[2019-07-17T15:03:36.268Z]  INFO: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:178 in _getSignaturesFromNetwork): Loading signatures from the network
[2019-07-17T15:03:36.269Z]  INFO: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:178 in _getSignaturesFromNetwork): Loading signatures from the network
[2019-07-17T15:03:36.270Z] ERROR: lisk-framework/69100 on Pablos-MacBook-Pro.local (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:111 in async.retry.err):
    Signatures loader TypeError: Cannot read property 'add' of undefined
        at Loader._getSignaturesFromNetwork (/Users/pablo/Documents/LISK/Repos/lisk-sdk/framework/src/modules/chain/loader.js:192:23)
        at process._tickCallback (internal/process/next_tick.js:68:7)```

### Steps to reproduce

### Which version(s) does this affect? (Environment, OS, etc...)

2.2.*
@shuse2
Copy link
Collaborator

shuse2 commented Jul 17, 2019

Signature sequence is not needed anymore

@pablitovicente pablitovicente changed the title Sequence not being injected in loader.js Sequence should not be used in loader.js Jul 17, 2019
@pablitovicente pablitovicente changed the title Sequence should not be used in loader.js Sequence should not be used in Loader Jul 17, 2019
shuse2 added a commit that referenced this issue Jul 18, 2019
…-in-loader

Sequence should not be used in Loader - Closes #3977
@shuse2 shuse2 closed this as completed Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants