Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Do not expose new/triedPeers from P2P #4044

Closed
ishantiw opened this issue Aug 5, 2019 · 0 comments
Closed

Do not expose new/triedPeers from P2P #4044

ishantiw opened this issue Aug 5, 2019 · 0 comments
Assignees
@diego-G
Labels
elements/P2P type: improvement
Milestone
Sprint 4

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Aug 5, 2019 •
edited by diego-G
Loading

Description

Right now we are exposing newPeers and triedPeers list by getNetworkStatus.

Motivation

We don't need to expose the lower level detail of peers as new/triedPeers.

Acceptance Criteria

P2P should return a list of connectedPeers and disconnectedPeers only. Also, update all the integration tests where we are using new/triedPeers

Additional Information
@ishantiw ishantiw mentioned this issue Aug 5, 2019
Merged
5 tasks
@sridharmeganathan sridharmeganathan added this to the Sprint 5 milestone Aug 20, 2019
@diego-G diego-G changed the title Remove getNetworkStatus from P2P that exposes new/triedPeers Do not expose new/triedPeers from P2P Aug 22, 2019
@diego-G diego-G mentioned this issue Aug 22, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Aug 26, 2019
@shuse2
Merge pull request #4125 from LiskHQ/4044-do_not_expose_new_tried_peers
1685b78 
Do not expose new or tried peers from P2P library - Close #4044
@shuse2 shuse2 closed this as completed Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
elements/P2P type: improvement
Projects
None yet
Milestone
Sprint 4
Development

No branches or pull requests
4 participants
@diego-G @shuse2 @ishantiw @sridharmeganathan