Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

PeerId is undefined while banning a peer in some cases #5028

Closed
ishantiw opened this issue Mar 18, 2020 · 0 comments · Fixed by #5029
Closed

PeerId is undefined while banning a peer in some cases #5028

ishantiw opened this issue Mar 18, 2020 · 0 comments · Fixed by #5029
Assignees
@ishantiw
Labels
elements/P2P type: bug
Milestone
Sprint 15

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Mar 18, 2020 •
edited
Loading

Expected behavior

Should log peerId on banning

Actual behavior

15:44:54.822Z ERROR lisk-framework: EVENT_MESSAGE_RECEIVED: Peer has been banned temporarily (module=lisk:app, peerId=undefined:undefined)
15:44:54.824Z DEBUG lisk-framework: Banned peer with Ip: undefined, reason: TypeError: Cannot read property 'length' of undefined, message: {"rid":1,"data":"pong"} (module=lisk:app)

Steps to reproduce

Run the application, connect to other nodes and check the logs

Which version(s) does this affect? (Environment, OS, etc...)

4.0.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
elements/P2P type: bug
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging a pull request may close this issue.

Fix variable and the condition for incoming payload - Closes #5028 LiskArchive/lisk-sdk
1 participant
@ishantiw