Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update lisk-chain to use encoded data to store #5264

Closed
shuse2 opened this issue May 4, 2020 · 0 comments · Fixed by #5367
Closed

Update lisk-chain to use encoded data to store #5264

shuse2 opened this issue May 4, 2020 · 0 comments · Fixed by #5367

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 4, 2020

Description

Update lisk-chain to receive decoded value based on new schema, and store encoded value.

  • Rename BlockInstance schema to Block, and update to the new schema defined in the LIP
  • Remove BlockJSON and similar types
  • Create block_adaptor to register asset schema per version
  • Rename serialze/deserialize to encode/decode
  • Update to store encoded value in storage and data access
  • Update lisk-chain to receive registeredBlockHeaders and accountAsset schema, and all account and block header should accept generic for the asset.
  • Update account state store to accept key as buffer
  • Update Account class to use the definition https://github.com/LiskHQ/lips/blob/master/proposals/lip-0030.md
  • Update block header to use the definition https://github.com/LiskHQ/lips/blob/master/proposals/lip-0029.md
  • Update lisk-cryptography usage in the framework

Motivation

In order to reduce the storage size, and consistently use the encoded value, chain should store the encoded data.

Acceptance Criteria

  • All tests are updated
  • Update all affected area using the block type
  • All unnecessary types are removed
  • Chain should not know the content of asset

Additional Information

Related LIP: https://github.com/LiskHQ/lips/blob/master/proposals/lip-0029.md

Related issues: #5200 #5238

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants