Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove usage of treeStructure in Merkle Tree #5491

Closed
mitsuaki-u opened this issue Jul 1, 2020 · 0 comments · Fixed by #5503
Closed

Remove usage of treeStructure in Merkle Tree #5491

mitsuaki-u opened this issue Jul 1, 2020 · 0 comments · Fixed by #5503
Assignees
@mitsuaki-u
Labels
elements/tree unplanned
Milestone
Sprint 22

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Jul 1, 2020 •
edited
Loading

Description

In order to build a proof, currently it is required to loop the tree structure with full nodes at each layer and node index.

This has a significant performance cost.

Motivation

In a hypothetical situation where storing all the blocks on mainnet into a merkle tree is required, we would require the most performant use of merkle tree.

Acceptance Criteria

Tree structure looping removed.

Additional Information

n/a
@mitsuaki-u mitsuaki-u self-assigned this Jul 1, 2020
@mitsuaki-u mitsuaki-u mentioned this issue Jul 1, 2020
Merged
@shuse2 shuse2 added this to the Sprint 22 milestone Jul 3, 2020
@ManuGowda ManuGowda mentioned this issue Jul 3, 2020
Closed
shuse2 added a commit that referenced this issue Jul 3, 2020
@shuse2
Merge pull request #5503 from LiskHQ/5491_improve_tree_performance
3b4a09d 
Benchmark and improve tree performance - Closes #5349 #5491
@mitsuaki-u mitsuaki-u linked a pull request Jul 3, 2020 that will close this issue
Benchmark and improve tree performance - Closes #5349 #5491 #5503
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitsuaki-u mitsuaki-u

Labels
elements/tree unplanned
Projects
None yet
Milestone
Sprint 22
Development

Successfully merging a pull request may close this issue.

Benchmark and improve tree performance - Closes #5349 #5491 LiskArchive/lisk-sdk
4 participants
@shuse2 @ManuGowda @mitsuaki-u @sridharmeganathan