You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
We need couple of refactoring around plugins and their declarations identified from the earlier PR.
Make plugin name a property rather the getter.
Rename function overridePluginOptions to updatePluginConfig to be consistent across naming convention.
Rename all files in plugins defaults/config.ts to cofnigSchema.ts or schema/config.ts
Don’t need the code objects.mergeDeep in every plugin load its already done in the base plugin.
Need to remove events and actions from abstract members and create properties with default values.
If possible create an issue to remove dependency of declaring nodeModulePath in every plugin.
Two functions _loadInMemoryPlugin and _loadChildProcessPlugin have extra parameter name. which can be removed now. Earlier it was the feature to register a plugin with different alias, now we restrict everywhere to just use plugin instance name.
Remove the use of assert around new code case
Motivation
Make plugin declaration and usage seamless and with minimum effort for Lisk SDK user.
Additional Information
For more details the discussion on this RR can be checked.
Description
We need couple of refactoring around plugins and their declarations identified from the earlier PR.
name
a property rather the getter.defaults/config.ts
tocofnigSchema.ts
orschema/config.ts
objects.mergeDeep
in every plugin load its already done in the base plugin.events
andactions
from abstract members and create properties with default values.nodeModulePath
in every plugin._loadInMemoryPlugin
and_loadChildProcessPlugin
have extra parametername
. which can be removed now. Earlier it was the feature to register a plugin with different alias, now we restrict everywhere to just use plugin instance name.Motivation
Make plugin declaration and usage seamless and with minimum effort for Lisk SDK user.
Additional Information
For more details the discussion on this RR can be checked.
#6664 (review)
The text was updated successfully, but these errors were encountered: