Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Schemas with repeated ids #8473

Closed
Tracked by #7226
shuse2 opened this issue May 22, 2023 · 0 comments
Closed
Tracked by #7226

Schemas with repeated ids #8473

shuse2 opened this issue May 22, 2023 · 0 comments
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented May 22, 2023

Expected behavior

Each schema $id should corresponds to a unique schema

Actual behavior

There are multiple duplicate $id property used

  • $id: '/block/header/3' in lisk-sdk/elements/lisk-chain/src/schema.ts#L102-L104 and lisk-sdk/elements/lisk-chain/src/schema.ts#L112-L114
  • $id: '/jsonRPCRequestSchema' in lisk-sdk/framework/src/controller/jsonrpc/utils.ts#L27-L28 and lisk-sdk/framework/src/controller/jsonrpc/utils.ts#L49-L50
  • $id: '/modules/random/endpoint/isSeedRevealRequest' in lisk-sdk/framework/src/modules/random/schemas.ts#L308-L309 and lisk-sdk/framework/src/modules/random/schemas.ts#L324-L325
  • $id: '/token/endpoint/getBalance' in lisk-sdk/framework/src/modules/token/schemas.ts#L494-L495 and lisk-sdk/framework/src/modules/token/schemas.ts#L448-L449
  • $id: '/auth/account' in lisk-sdk/framework/src/modules/auth/schemas.ts#L22-L23 and lisk-sdk/framework/src/modules/auth/stores/auth_account.ts#L25-L26
  • $id: '/block/event' in lisk-sdk/framework/src/abi/schema.ts#L30-L31 and lisk-sdk/elements/lisk-chain/src/schema.ts#L187-L188
  • $id: '/commander/plainGeneratorKeys' in isk-sdk/commander/src/bootstrapping/commands/keys/encrypt.ts#L37-L38 and lisk-sdk/commander/src/bootstrapping/commands/keys/create.ts#L24-L25
  • $id: '/modules/random/seedReveal' in lisk-sdk/framework/src/modules/random/stores/validator_reveals.ts#L29-L30 and lisk-sdk/framework/src/modules/random/schemas.ts#L196-L197
  • $id: '/token/store/escrow' in lisk-sdk/framework/src/modules/token/schemas.ts#L109-L110 and lisk-sdk/framework/src/modules/token/stores/escrow.ts#L23-L24
  • $id: '/token/store/supply' in lisk-sdk/framework/src/modules/token/schemas.ts#L77-L78 and lisk-sdk/framework/src/modules/token/stores/supply.ts#L21-L22
  • $id: '/node/forger/usedHashOnion' in lisk-sdk/framework/src/modules/random/stores/used_hash_onions.ts#L30-L32 and lisk-sdk/framework/src/modules/random/schemas.ts#L276-L278
  • $id: '/token/store/user' in lisk-sdk/framework/src/modules/token/stores/user.ts#L27-L28 and lisk-sdk/examples/interop/pos-mainchain-fast/config/scripts/recover_lsk_plugin.ts#L 68-L69 and lisk-sdk/framework/src/modules/token/schemas.ts#L52-L53

Steps to reproduce

Check the list above. Also, check all $id with grep and verify the source code again

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-beta.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants