Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix duplicate schema $id and add github action check #8594

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Jun 14, 2023

What was the problem?

This PR resolves #8473

How was it solved?

  • Add script to check duplicate $id on source code (ignoring test/node_modules etc)
  • Add check to Github action PR check
  • Fix duplicate $id

How was it tested?

N/A

@shuse2 shuse2 self-assigned this Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #8594 (4704457) into release/6.0.0 (c4e9d75) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4704457 differs from pull request most recent head 6b72f3a. Consider uploading reports for the commit 6b72f3a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #8594      +/-   ##
=================================================
- Coverage          83.25%   83.25%   -0.01%     
=================================================
  Files                593      593              
  Lines              22250    22241       -9     
  Branches            3279     3279              
=================================================
- Hits               18525    18516       -9     
  Misses              3725     3725              
Impacted Files Coverage Δ
commander/test/helpers/transactions.ts 96.00% <ø> (-0.16%) ⬇️
elements/lisk-api-client/src/codec.ts 67.51% <ø> (ø)
elements/lisk-chain/src/schema.ts 100.00% <ø> (ø)
framework/src/abi/schema.ts 100.00% <ø> (ø)
framework/src/controller/jsonrpc/utils.ts 88.88% <ø> (ø)
framework/src/modules/auth/schemas.ts 100.00% <ø> (ø)
framework/src/modules/token/schemas.ts 100.00% <ø> (ø)
...ommander/src/bootstrapping/commands/keys/create.ts 100.00% <100.00%> (ø)
...mmander/src/bootstrapping/commands/keys/encrypt.ts 100.00% <100.00%> (ø)
commander/src/constants.ts 100.00% <100.00%> (ø)
... and 4 more

@shuse2 shuse2 requested review from mosmartin and bobanm June 15, 2023 02:02
@shuse2 shuse2 force-pushed the 8473-fix-duplicate-schema-id branch from 802448e to a8e26e3 Compare June 15, 2023 03:36
Copy link
Contributor

@bobanm bobanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a minor improvement suggestion.

scripts/duplicate_schema_id.js Outdated Show resolved Hide resolved
@shuse2 shuse2 enabled auto-merge (squash) June 19, 2023 07:46
@shuse2 shuse2 merged commit 89085a6 into release/6.0.0 Jun 19, 2023
@shuse2 shuse2 deleted the 8473-fix-duplicate-schema-id branch June 19, 2023 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants