Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

registerValidatorKeys implementation in Validator module returns boolean #8564

Closed
Tracked by #7226
mitsuaki-u opened this issue Jun 8, 2023 · 2 comments
Closed
Tracked by #7226

registerValidatorKeys implementation in Validator module returns boolean #8564

mitsuaki-u opened this issue Jun 8, 2023 · 2 comments
Assignees
@mosmartin
Labels
framework type: bug
Milestone
Sprint 98

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Jun 8, 2023 •
edited
Loading

Expected behavior

registerValidatorKeys implementation in Validator module differs slightly from LIP.

See comment: #8525 (comment)

Actual behavior

returns true for success and false when invalid key. in the LIP it merely throws an error for anything besides success.

Steps to reproduce

Check Validators module registerValidatorKeys versus LIP

Which version(s) does this affect? (Environment, OS, etc...)

6.0
@mitsuaki-u
Copy link
Contributor Author

CC: @sergeyshemyakov

@mosmartin
Copy link
Contributor

@mitsuaki-u would you kindly add a link to the LIP (part that it should align with)? 🙏

@Madhulearn Madhulearn added this to the Sprint 98 milestone Jun 20, 2023
@Madhulearn Madhulearn mentioned this issue Jun 20, 2023
Closed
@mosmartin mosmartin mentioned this issue Jun 21, 2023
Merged
@shuse2 shuse2 closed this as completed Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mosmartin mosmartin

Labels
framework type: bug
Projects
None yet
Milestone
Sprint 98
Development

No branches or pull requests
4 participants
@shuse2 @mosmartin @mitsuaki-u @Madhulearn