Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Align the registerValidatorKeys method to LIP #8633

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

mosmartin
Copy link
Contributor

What was the problem?

This PR resolves #8564

How was it solved?

Align registerValidatorKeys method to lip

How was it tested?

Updatedunit tests

@mosmartin mosmartin requested review from shuse2 and bobanm June 21, 2023 12:09
@mosmartin mosmartin self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #8633 (6af4137) into release/6.0.0 (4709bdd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8633   +/-   ##
==============================================
  Coverage          83.23%   83.24%           
==============================================
  Files                593      593           
  Lines              22255    22250    -5     
  Branches            3289     3287    -2     
==============================================
- Hits               18525    18522    -3     
+ Misses              3730     3728    -2     
Impacted Files Coverage Δ
framework/src/modules/validators/method.ts 90.84% <ø> (-0.07%) ⬇️
...ork/src/modules/pos/commands/register_validator.ts 100.00% <100.00%> (+2.38%) ⬆️
framework/src/modules/pos/module.ts 96.43% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

@mosmartin mosmartin force-pushed the 8564-align-validator-module-to-lip branch from 37a7e5c to 0aa0022 Compare June 23, 2023 11:19
@mosmartin mosmartin requested a review from bobanm June 23, 2023 11:19
- align registerValidatorKeys method to lip
- update unit tests

Update unit test
@mosmartin mosmartin force-pushed the 8564-align-validator-module-to-lip branch from 0aa0022 to 6af4137 Compare June 23, 2023 15:57
@shuse2 shuse2 merged commit b16f9f7 into release/6.0.0 Jun 26, 2023
10 checks passed
@shuse2 shuse2 deleted the 8564-align-validator-module-to-lip branch June 26, 2023 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants