This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix undefined logger in Votes logic - Closes #3224 #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
approved these changes
Mar 29, 2019
lsilvs
approved these changes
Mar 29, 2019
shuse2
deleted the
3224-Account_module_assigns_undefined_logger_votes_logic
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Votes logic was being initialized with undefined logger. This causes problems in Votes logic when expections happen.
How did I fix it?
Assigning correct non-undefined logger to Votes logic
How to test it?
To speedup QA phase I will fully test Accounts submodule constructor on Monday.
Review checklist