This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix loader expectation and add configs - Closes #3591 #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the title
pablitovicente
approved these changes
May 13, 2019
jondubois
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Response was expecting wrong format
How did I fix it?
Update to extract correct format
How to test it?
Sync with the testnet, and observe it has correct response.
put above after
https://github.com/LiskHQ/lisk-sdk/pull/3592/files#diff-a37a28379e9954d0ebb1d0c3f44784bfL208
Review checklist