This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Confirmations value in block is NaN - Close #3688 #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block from network
lsilvs
reviewed
May 22, 2019
Co-Authored-By: Lucas <[email protected]>
shuse2
suggested changes
May 22, 2019
pablitovicente
requested review from
lsilvs and
shuse2
and removed request for
lsilvs
shuse2
approved these changes
May 22, 2019
pablitovicente
force-pushed
the
3688-confirmations-value-in-block-is-nan
branch
from
a0679ce
to
bc0e6db
Compare
pablitovicente
force-pushed
the
3688-confirmations-value-in-block-is-nan
branch
from
bc0e6db
to
30294dd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
How did I fix it?
confirmationsis not present in the blocks when callingdbReadorstorageReadwhen receiving blocksHow to test it?
chain:blocks:changeconfirmations should not beNaNReview checklist