This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Create README for custom transactions - Closes #3164 #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Baj <[email protected]>
SargeKhan
reviewed
May 28, 2019
Co-Authored-By: Usman <[email protected]>
Co-Authored-By: Usman <[email protected]>
shuse2
suggested changes
May 28, 2019
Tschakki
reviewed
May 28, 2019
Tschakki
reviewed
May 28, 2019
Co-Authored-By: Mona Bärenfänger <[email protected]>
Signed-off-by: Maciej Baj <[email protected]>
Signed-off-by: Maciej Baj <[email protected]>
shuse2
requested review from
Tschakki and
SargeKhan
and removed request for
Tschakki
shuse2
approved these changes
Jun 4, 2019
SargeKhan
reviewed
Jun 4, 2019
Tschakki
reviewed
Jun 4, 2019
There was a problem hiding this comment.
Maybe the order of the methods can be improved to
- prepare
- validateAsset
- applyAsset
- undoAsset
analog to docs: https://github.com/LiskHQ/lisk-docs/blob/235-hello-world-app/custom-transactions.md
Correct the overview of `prepare` step Co-Authored-By: Usman <[email protected]>
MaciejBaj
commented
Jun 4, 2019
Tschakki
approved these changes
Jun 5, 2019
mitsuaki-u
suggested changes
Jun 12, 2019
MaciejBaj
commented
Jun 14, 2019
MaciejBaj
commented
Jun 14, 2019
MaciejBaj
force-pushed
the
3164-custom_transaction_readme
branch
2 times, most recently
from
0425ee1
to
92efe6f
Compare
MaciejBaj
force-pushed
the
3164-custom_transaction_readme
branch
from
92efe6f
to
c294c90
Compare
Signed-off-by: Maciej Baj <[email protected]>
MaciejBaj
force-pushed
the
3164-custom_transaction_readme
branch
from
c294c90
to
bf734f3
Compare
Signed-off-by: Maciej Baj <[email protected]>
Signed-off-by: Maciej Baj <[email protected]>
mitsuaki-u
approved these changes
Jun 17, 2019
MaciejBaj
commented
Jun 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Missing README.md file describing the custom transactions interface.
How did I fix it?
Included the explanation of:
Review checklist