This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
application_config_schema.js not being used and Application/Schema invalid syntax - Closes #3939 #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for application schema config
…d max trs per block
nazarhussain
suggested changes
Jul 10, 2019
… and deleting added test
@@ -159,12 +164,12 @@ module.exports = { | |||
}, | |||
OFFSET: { | |||
type: 'integer', | |||
min: 1, | |||
minimum: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, here is the specification for this change.
https://json-schema.org/latest/json-schema-validation.html#rfc.section.6.2.4
nazarhussain
approved these changes
Jul 11, 2019
shuse2
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
min
andmax
instead ofminimum
andmaximum
How did I fix it?
How to test it?
framework/test/fixtures/config/devnet/config.json
with values that will fail validation and application should not startReview checklist