Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

application_config_schema.js not being used and Application/Schema invalid syntax - Closes #3939 #3940

Merged
merged 6 commits into from
Jul 12, 2019

Conversation

pablitovicente
Copy link
Contributor

@pablitovicente pablitovicente commented Jul 9, 2019

What was the problem?

How did I fix it?

  • application_config_schema.js is being validated.
  • schema is using min and max instead of minimum and maximum for limits which is invalid and pass validation with invalid values

How to test it?

  • Build should be green
  • Change framework/test/fixtures/config/devnet/config.json with values that will fail validation and application should not start

Review checklist

@@ -159,12 +164,12 @@ module.exports = {
},
OFFSET: {
type: 'integer',
min: 1,
minimum: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, here is the specification for this change.

https://json-schema.org/latest/json-schema-validation.html#rfc.section.6.2.4

@shuse2 shuse2 merged commit d1a4662 into release/2.1.0 Jul 12, 2019
@shuse2 shuse2 deleted the 3939-fix-sdk-schemas branch July 12, 2019 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants