This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Throw error for non-existent action and add tests - Closes #4080 #4081 #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuGowda
reviewed
Aug 16, 2019
ManuGowda
approved these changes
Aug 16, 2019
shuse2
approved these changes
Aug 16, 2019
jondubois
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
See #4070
How did I solve it?
Add error message and tests for non-existent actions for
invokeandinvokePublic.How to manually test it?
npm run jest:unit -- test/jest/unit/specs/controller/bus.spec.jsOr request a nonexisting action from chain module on startup (inside
bootstrap()function).Review checklist