Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Create an unlocking transaction command - Closes #4929 #5069

Merged
merged 9 commits into from
Mar 31, 2020
Merged

Create an unlocking transaction command - Closes #4929 #5069

merged 9 commits into from
Mar 31, 2020

Conversation

ManuGowda
Copy link
Contributor

What was the problem?

This PR resolves #4929

How was it solved?

  • Added new unlock command

How was it tested?

  • Run command
./bin/run transaction:create --type=unlock 1 100000000 --unlock="123L,1000000000,500" --unlock="456L,1000000000,500" --passphrase="123"

./bin/run transaction:create:unlock 1 100000000 --unlock="456L,1000000000,500" --passphrase="123"

./bin/run transaction:create:unlock 1 100000000 --unlock="123L,1000000000,500" --unlock="456L,1000000000,500" --passphrase="123"

./bin/run transaction:create:unlock 1 100000000 --unlock="123L,1000000000,500" --unlock="456L,1000000000,500" --no-signature

@ManuGowda ManuGowda self-assigned this Mar 30, 2020
shuse2
shuse2 suggested changes Mar 31, 2020
View reviewed changes
commander/src/commands/transaction/create/unlock.ts Outdated Show resolved Hide resolved
commander/test/commands/transaction/create.test.ts Outdated Show resolved Hide resolved
commander/test/commands/transaction/create.test.ts Outdated Show resolved Hide resolved
commander/test/commands/transaction/create.test.ts Outdated Show resolved Hide resolved
commander/src/commands/transaction/create/unlock.ts Outdated Show resolved Hide resolved
commander/src/commands/transaction/create/unlock.ts Outdated Show resolved Hide resolved
commander/src/commands/transaction/create/unlock.ts Outdated Show resolved Hide resolved
@ManuGowda ManuGowda requested a review from shuse2 March 31, 2020 07:19
nazarhussain
nazarhussain suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one feedback.

commander/src/commands/transaction/create/unlock.ts Outdated Show resolved Hide resolved
@ManuGowda ManuGowda merged commit 34dd1bb into development Mar 31, 2020
@ManuGowda ManuGowda deleted the 4929-create-unlock-command branch March 31, 2020 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@nazarhussain nazarhussain nazarhussain approved these changes

Assignees

@ManuGowda ManuGowda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an unlocking transaction command
3 participants
@ManuGowda @nazarhussain @shuse2