This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update lisk-chain to use lisk-db - Closes #5257 #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
changed the title
shuse2
changed the title
shuse2
force-pushed
the
5257-update_db_usage
branch
from
0f8dd21
to
7bbc3de
Compare
shuse2
requested review from
pablitovicente,
mitsuaki-u,
ManuGowda,
ishantiw and
nazarhussain
nazarhussain
suggested changes
May 12, 2020
Comment on lines
+420
to
+422
| const batch = this._db.batch(); | ||
| stateStore.finalize(batch); | ||
| await batch.write(); |
There was a problem hiding this comment.
Can we move this logic to dataAccess object?
shuse2
force-pushed
the
5257-update_db_usage
branch
from
7bbc3de
to
15594d7
Compare
pablitovicente
approved these changes
May 13, 2020
shuse2
force-pushed
the
5257-update_db_usage
branch
from
275d767
to
c93574d
Compare
shuse2
force-pushed
the
5257-update_db_usage
branch
from
c93574d
to
20d91cb
Compare
shuse2
force-pushed
the
5257-update_db_usage
branch
from
20d91cb
to
624c247
Compare
shuse2
force-pushed
the
5257-update_db_usage
branch
from
624c247
to
febfaf6
Compare
nazarhussain
approved these changes
May 14, 2020
ManuGowda
approved these changes
May 14, 2020
ishantiw
reviewed
May 14, 2020
ishantiw
approved these changes
May 14, 2020
mitsuaki-u
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5257
How was it solved?
preparestep from transactionsHow was it tested?