This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add monitoring and reportMisbehavior plugin setups - Closes #5876 and #5291 #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
force-pushed
the
5878-5291_add_plugin_folders
branch
from
4742b8b
to
5488e96
Compare
shuse2
changed the title
shuse2
force-pushed
the
5878-5291_add_plugin_folders
branch
from
5488e96
to
849fdb5
Compare
shuse2
force-pushed
the
5878-5291_add_plugin_folders
branch
from
bb83040
to
eacdb5a
Compare
mitsuaki-u
suggested changes
Oct 20, 2020
There was a problem hiding this comment.
Missing one config in PoM. Also as @pablitovicente mentioned perhaps it is good to add empty controllers and routes.
framework-plugins/lisk-framework-report-misbehavior-plugin/src/defaults/default_config.ts
Show resolved
Hide resolved
ishantiw
reviewed
Oct 20, 2020
framework-plugins/lisk-framework-report-misbehavior-plugin/package.json
Outdated
Show resolved
Hide resolved
mitsuaki-u
approved these changes
Oct 20, 2020
ishantiw
approved these changes
Oct 20, 2020
This was referenced Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5876 and resolves #5291
How was it solved?
monitor-pluginandreport-misbehavior-pluginHow was it tested?