This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
Create plugin bootstrap command and templates - Closes #6072 #6093
Merged
shuse2
merged 29 commits into
feature/6066-commander-bootstraping
from
6072_plugin_bootstrap
Jan 27, 2021
Merged
Create plugin bootstrap command and templates - Closes #6072 #6093
shuse2
merged 29 commits into
feature/6066-commander-bootstraping
from
6072_plugin_bootstrap
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
changed the title
Create Plugin bootstrap command and templates - Closes #6072
Create plugin bootstrap command and templates - Closes #6072
Jan 26, 2021
nazarhussain
suggested changes
Jan 26, 2021
commander/src/bootstrapping/templates/lisk-template-ts/generators/plugin_generator.ts
Outdated
Show resolved
Hide resolved
commander/src/bootstrapping/templates/lisk-template-ts/generators/plugin_generator.ts
Outdated
Show resolved
Hide resolved
commander/src/bootstrapping/templates/lisk-template-ts/generators/plugin_generator.ts
Outdated
Show resolved
Hide resolved
mitsuaki-u
force-pushed
the
6072_plugin_bootstrap
branch
from
January 26, 2021 13:43
dbecd6f
to
1a87423
Compare
mitsuaki-u
force-pushed
the
6072_plugin_bootstrap
branch
from
January 26, 2021 16:21
4c885d0
to
b2af148
Compare
...er/src/bootstrapping/templates/lisk-template-ts/templates/plugin/test/unit/plugins/plugin.ts
Outdated
Show resolved
Hide resolved
nazarhussain
approved these changes
Jan 26, 2021
mitsuaki-u
force-pushed
the
6072_plugin_bootstrap
branch
from
January 27, 2021 08:32
11523df
to
7db4628
Compare
ishantiw
reviewed
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor comments
...nder/src/bootstrapping/templates/lisk-template-ts/templates/plugin/src/app/plugins/plugin.ts
Outdated
Show resolved
Hide resolved
commander/src/bootstrapping/templates/lisk-template-ts/generators/plugin_generator.ts
Outdated
Show resolved
Hide resolved
...er/src/bootstrapping/templates/lisk-template-ts/templates/plugin/test/unit/plugins/plugin.ts
Outdated
Show resolved
Hide resolved
...nder/src/bootstrapping/templates/lisk-template-ts/templates/plugin/src/app/plugins/plugin.ts
Outdated
Show resolved
Hide resolved
ishantiw
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6072
How was it solved?
Create generate:plugin command in lisk-commander
Create
lisk-ts
template for pluginCreate
lisk-ts
template for plugin unit testsCreate base plugin generator
Create
lisk-ts
plugin generatorHow was it tested?
Run
generate:plugin
and observe created files